This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[multiple] Remove custom analysis_options.yaml from web plugins. #3238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amirh
approved these changes
Oct 31, 2020
Contributor
amirh
left a comment
amirh
left a comment
There was a problem hiding this comment.
Thanks! LGTM
If we see this as a temporary workaround we should probably have TODOs to remove it on all files. If it's a permanent solution we should probably put the workaround in a common package.
packages/google_maps_flutter/google_maps_flutter_web/lib/src/shims/dart_ui.dart
Show resolved
Hide resolved
Contributor
|
Note that the broken analyzer is due to null safety being turned on by default, see discussion on: flutter/flutter#69440 (comment) |
Substitute `undefined_prefixed_name: ignore` analyzer setting by a `dart:ui` shim with conditional exports for the following plugins: * video_player_web * google_maps_flutter_web * url_launcher_web
ditman
force-pushed
the
remove-analysis-yaml
branch
from
fcd8670 to
f53fa5e
Compare
Member
Author
|
Rebased on top of the latest master. |
fesp
pushed a commit
to fesp/plugins
that referenced
this pull request
Nov 11, 2020
…tter#3238) Substitute `undefined_prefixed_name: ignore` custom analyzer setting by a `dart:ui` shim with conditional exports for the following plugins: * video_player_web * google_maps_flutter_web * url_launcher_web Remove these plugins from the CUSTOM_ANALYSIS_PLUGINS list in `script/incremental_build.sh`
9 tasks
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
…tter#3238) Substitute `undefined_prefixed_name: ignore` custom analyzer setting by a `dart:ui` shim with conditional exports for the following plugins: * video_player_web * google_maps_flutter_web * url_launcher_web Remove these plugins from the CUSTOM_ANALYSIS_PLUGINS list in `script/incremental_build.sh`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Substitute
undefined_prefixed_name: ignoreanalyzer setting by adart:uishim with conditional exports for the following plugins:Related Issues
video_player_web tests
Video player web tests are broken (with nnbd errors), but so are in
master. I'll migrate them to run withflutter driveinstead offlutter test --platform chrome, which is being deprecated.Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?