This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[wifi_info_flutter_platform_interface] Ready to publish #3190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Please make sure to wait for @bparrishMines's approval before landing. |
Member
Contributor
bparrishMines
left a comment
bparrishMines
left a comment
There was a problem hiding this comment.
In the pubspec.yaml, we should change
wifi_info_flutter_platform_interface:
path: ../wifi_info_flutter_platform_interface
to
wifi_info_flutter_platform_interface: 1.0.0
It will cause the PR to fail until it is published though.
Contributor
Author
|
@bparrishMines How about we only land the platform interface change in the PR, publish interface, then land another PR for the plugin change. |
cyanglaz
changed the title
bparrishMines
approved these changes
Oct 22, 2020
Contributor
bparrishMines
left a comment
bparrishMines
left a comment
There was a problem hiding this comment.
@cyanglaz That plan works for me.
LGTM
Contributor
Author
|
Im going to land on red as the failure are about not updating the version. This PR didn't update the version because the last version wasn't published. |
Contributor
Author
|
@bparrishMines actually, it looks like the version in CHANGELOG.MD and pubspec didn't match. I fixed it, could you take another look? |
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the plugins ready to be published