This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[connectivity] announce 1.0, deprecate wifi APIs #3183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 21, 2020 12:57
amirh
approved these changes
Oct 21, 2020
| expect(result, isNotNull); | ||
| switch (result) { | ||
| case ConnectivityResult.wifi: | ||
|
|
ditman
approved these changes
Oct 22, 2020
Member
ditman
left a comment
ditman
left a comment
There was a problem hiding this comment.
LGTM! it needs a pass of dartfmt -w . however.
| /// From Android 8.0 onwards the GPS must be ON (high accuracy) | ||
| /// in order to be able to obtain the BSSID. | ||
| @Deprecated( | ||
| 'This method is deprecated. Please use wifi_info_flutter instead. See https://github.com/flutter/plugins/blob/master/packages/wifi_info_flutter/wifi_info_flutter/README.md') |
Member
There was a problem hiding this comment.
Why not a link to pub.dev? It'd be much shorter!
Contributor
Author
There was a problem hiding this comment.
wifi_info_flutter is not published yet :(
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bump the version to 1.0.0, announce deprecations to all wifi related APIs