Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@cyanglaz
Copy link
Contributor

Fixes the ci failure:

Checking project camera...
  info - 'showSnackBar' is deprecated and shouldn't be used. Use ScaffoldMessenger.showSnackBar. This feature was deprecated after v1.23.0-14.0.pre. at example/lib/main.dart:275:31 - (deprecated_member_use)

https://cirrus-ci.com/task/4518227873103872?command=main#L292

This only fix the deprecation warning in camera and webview_flutter, the error in url_launcher_web should be fixed with #3155

Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM!

@cyanglaz
Copy link
Contributor Author

cyanglaz commented Oct 20, 2020

Well, the API is not in stable. I'm going to add the allow warning instead of fixing it.

@cyanglaz
Copy link
Contributor Author

@ditman updated with ignore warning, PTAL

Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once tests pass. What is the method being replaced by?

Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this is way simpler.

@cyanglaz
Copy link
Contributor Author

Landing on red to fix ci.

@cyanglaz cyanglaz merged commit ec6a392 into flutter:master Oct 20, 2020
@cyanglaz cyanglaz deleted the deprecation_fix branch October 20, 2020 22:47
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants