Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@blasten
Copy link

@blasten blasten commented Sep 18, 2020

Migrates video_player to nnbd
Status: WIP

Fixes: flutter/flutter#66394

import 'dart:async';
import 'package:flutter/services.dart';

// @dart = 2.8
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @gaaclarke - any plans to add this to Pigeon or migrate it to null safety?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add the comment to pigeon for now and upgrade it in the future, thanks.

@blasten
Copy link
Author

blasten commented Sep 18, 2020

FYI @amirh

When Linux support was added to these plugins, the app template wasn't
yet stabilized, so was not checked in. Now that it is stable, this adds
them so that the plugin_tools workaround that created them on each run
can be removed.

Other than CHANGELOG.md updates and updating the verison in
pubspec.yaml, this is purely the result of running 'flutter create .' in
the example/ folders and adding the resulting linux/ directories.
@blasten blasten closed this Oct 14, 2020
@blasten blasten deleted the nnbd branch October 14, 2020 01:55
@blasten blasten restored the nnbd branch October 14, 2020 01:57
@blasten blasten deleted the nnbd branch October 14, 2020 01:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.