You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Feb 22, 2023. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PR includes an entire iOS lifecycle, allowing the actions to trigger when the app is in the background and/or not running.
Also modified the Dart example to provide a more accurate view of what is going on by using a dialog rather than changing the title bar (the title bar was not changing when triggered without actions, making it more confusing for the developer)
Related Issues
N/A
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.
[X ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ X] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[ X] All existing and new tests are passing.
[ X] I updated/added relevant documentation (doc comments with ///).
[ X] The analyzer (flutter analyze) does not report any problems on my PR.
I can't get QuickActions to fire on iOS at all, so I'm hoping this PR will fix it - thank you @olivierbrand . Is there anyway for me to easily test your changes locally? I hope the Flutter team can look at them. I saw your previous PR sat around for ages with no action :-(
This PR fixes our issues with quick_actions on iOS. To use is in your project @jonmountjoy, use this is your pubspec.yaml:
quick_actions: # in place till this PR is merged: https://github.com/flutter/plugins/pull/2887git:
url: https://github.com/Ingenio/flutter-pluginspath: packages/quick_actions
Thanks for the contribution! We apologize for the long delay in triaging this PR. We’re in the process of overhauling our PR triage system to respond much more quickly, as well as working through the backlog.
We're in the process of working through various issues and PRs related to quick_actions (/cc @mvanbeusekom) so we should be able to get this into the review queue. However, I'm not seeing the tests in the PR that you've indicated in the checklist are included; please be sure you've added those to the PR that's been pushed here.
Thanks for the contribution! We apologize for the long delay in triaging this PR. We’re in the process of overhauling our PR triage system to respond much more quickly, as well as working through the backlog.
No problem
We're in the process of working through various issues and PRs related to quick_actions (/cc @mvanbeusekom) so we should be able to get this into the review queue. However, I'm not seeing the tests in the PR that you've indicated in the checklist are included; please be sure you've added those to the PR that's been pushed here.
I am unsure this can be automatically tested as it involves the home screen of the phone. What was fixed is a collection of things including mainly the underlying mobile platforms lifecycle events, not sure this is testable
At least the backgrounded app case should be testable via integration tests.
Not sure, can you trigger a long press on home screen to validate this? How would you do these tests, also a critical one was: app killed on iOS. Thanks for pointing me in the right direction or any other help is welcome
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The PR includes an entire iOS lifecycle, allowing the actions to trigger when the app is in the background and/or not running.
Also modified the Dart example to provide a more accurate view of what is going on by using a dialog rather than changing the title bar (the title bar was not changing when triggered without actions, making it more confusing for the developer)
Related Issues
N/A
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?