Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[url_launcher_web] Add tel URL support #2847

Merged
ditman merged 4 commits into from
Jun 30, 2020
Merged

[url_launcher_web] Add tel URL support #2847

ditman merged 4 commits into from
Jun 30, 2020

Conversation

@Vanethos
Copy link
Contributor

@Vanethos Vanethos commented Jun 25, 2020 •
edited by ditman
Loading

Description

Adds the ability to open tel URLS in web

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • No, this is not a breaking change.

@Vanethos Vanethos changed the title [url_launcher] Adds tel [url_launcher] Adds tel URL in Web Jun 25, 2020
ditman
ditman suggested changes Jun 25, 2020
View reviewed changes
Copy link
Member

@ditman ditman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[x] I updated CHANGELOG.md to add a description of the change.

No you didn't 😜

You need to bump the version on the pubspec.yaml of url_launcher_web, and update its CHANGELOG.md.

An appropriate version for this change would be: 0.1.2, IMO.

@Bilonik Bilonik mentioned this pull request Jun 28, 2020
Closed
13 tasks
@ditman ditman changed the title [url_launcher] Adds tel URL in Web [url_launcher_web] Adds tel URL support Jun 29, 2020
@ditman ditman changed the title [url_launcher_web] Adds tel URL support [url_launcher_web] Add tel URL support Jun 29, 2020
@Vanethos
Adds "sms" support
ff197be 
Adds tests for "tel" and sms
@ditman
Copy link
Member

ditman commented Jun 30, 2020

Thanks for adding the "sms" protocol! The only missing thing is to run dartfmt -w . to make the "format" check happy!

@ditman ditman self-assigned this Jun 30, 2020
@Vanethos
Copy link
Contributor Author

Vanethos commented Jun 30, 2020

oh my! forgot about that, sorry!

Done :D

@ditman ditman self-requested a review June 30, 2020 18:40
@ditman
Copy link
Member

ditman commented Jun 30, 2020

This looks great, let's merge and publish it! Thanks for the contribution @Vanethos!!

@ditman ditman merged commit 940c10c into flutter:master Jun 30, 2020
@Vanethos
Copy link
Contributor Author

Vanethos commented Jun 30, 2020

Many many thanks for the patience and time @ditman !

It was really fun :D

@ditman
Copy link
Member

ditman commented Jun 30, 2020

This change has passed the post-submit checks and has been published as url_launcher_web 0.1.2!

agent3bood pushed a commit to agent3bood/flutter-plugins that referenced this pull request Jul 10, 2020
@Vanethos @agent3bood
[url_launcher_web] Adds "tel" and "sms" URL support (flutter#2847)
e7b6cff
jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
@Vanethos @jorgefspereira
[url_launcher_web] Adds "tel" and "sms" URL support (flutter#2847)
8c50326
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
@Vanethos
[url_launcher_web] Adds "tel" and "sms" URL support (flutter#2847)
4a6bc68
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@ditman ditman ditman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ditman ditman

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[url_launcher_web] Cannot launch url with scheme tel [url_launcher] for web should support the tel and sms scheme in PWA

3 participants

@Vanethos @ditman @googlebot