[web] Introduce the Link widget #2813
Conversation
mdebbar
force-pushed
the
link_platform_view
branch
from
4e0d8a1 to
5635de1
Compare
mdebbar
changed the title
mdebbar
requested review from
ditman and
harryterkelsen
and removed request for
mklim
| // TODO(mdebbar): how do we know if this is true or false? | ||
| final bool isUsingRouter = false; | ||
| // QUESTION: does this update the history entry on the engine side? | ||
| final MethodCall call = isUsingRouter | ||
| ? MethodCall('pushRouteInformation', <dynamic, dynamic>{ | ||
| 'location': routeName, | ||
| 'state': null, | ||
| }) | ||
| : MethodCall('pushRoute', routeName); |
There was a problem hiding this comment.
@chunhtai is there a way currently to tell if the app is in Router mode? Maybe inspect the widget hierarchy for a Router widget?
There was a problem hiding this comment.
there is no standard API to check that. Since this is a separate package, i think just do a Router.of(context, nullOk: true) != null should be fine
| @override | ||
| Future<void> clearFocus() async { | ||
| // Currently this does nothing on Flutter Web. | ||
| // TODO(het): Implement this. See https://github.com/flutter/flutter/issues/39496 |
There was a problem hiding this comment.
This was copied from the similar implementation in the framework. Not sure what's the right thing to do here @hterkelsen.
harryterkelsen
left a comment
harryterkelsen
left a comment
There was a problem hiding this comment.
Code LGTM. Unfortunate that we have to use PlatformViewLink here for a pretty simple use case. This highlights how much we need to flesh out/fix HtmlElementView.
In order to actually land this, you will need to split it up into 2 CLs: one which lands the changes in the _interface package (with CHANGELOG and pubspec version bump) and one which uses those changes in package:url_launcher.
| widget.link.isDisabled ? null : _followLink, | ||
| ), | ||
| Positioned.fill( | ||
| // child: _LinkHtmlView(uri: link.uri, target: link.target), |
There was a problem hiding this comment.
delete this line and add a TODO to use a PlatformView once hit testing is fixed and creation parameters supported
|
(Moved my review to the PRs above) |
5 participants
This PR introduces the Link widget and provides an implementation for the web.
The design of this widget has been discussed in:
Issues: