This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[connectivity, battery, android_alarm_manager] v2 support #2613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 tasks
GaryQian
requested review from
amirh,
bkonyi and
matthew-carroll
as code owners
GaryQian
changed the title
bkonyi
approved these changes
Mar 20, 2020
Contributor
bkonyi
left a comment
bkonyi
left a comment
There was a problem hiding this comment.
Alarm manager changes LGTM
GaryQian
commented
Mar 20, 2020
| @@ -1,9 +1,9 @@ | |||
| package io.flutter.plugins.androidalarmmanagerexample; | |||
|
|
|||
| import io.flutter.app.FlutterApplication; | |||
Contributor
Author
There was a problem hiding this comment.
Is the entire Application.java file still necessary in V2 embedding?
Contributor
Author
There was a problem hiding this comment.
The README says that V2 should handle this via reflection. Is it safe to just delete this file?
Member
There was a problem hiding this comment.
@bkonyi my read is that this file is still needed (since we have one application for both the (new)FlutterActivity and the EmbeddingV1Activity.java). So this file looks fine to me.
|
Since the Android Alarm Manager plugin now supports only Flutter >= 1.12.13+hotfix.5, should we remove examples of inclusion via the V1 embedding? It looks like we could:
<application android:name="io.flutter.app.FlutterApplication" >
<activity
android:name="io.flutter.plugins.androidalarmmanagerexample.EmbeddingV1Activity"
android:launchMode="singleTop"
android:theme="@style/LaunchTheme"
android:configChanges="orientation|keyboardHidden|keyboard|screenSize|locale|layoutDirection"
android:hardwareAccelerated="true"
android:windowSoftInputMode="adjustResize"
android:exported="true">
</activity>
If you think these tasks can be done I'd be happy to open a PR. |
EdwinRomelta
pushed a commit
to EdwinRomelta/plugins
that referenced
this pull request
Jun 11, 2020
jorgefspereira
pushed a commit
to jorgefspereira/plugins_flutter
that referenced
this pull request
Oct 10, 2020
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Embedder V2 support connectivity, battery, and android alarm manager plugins
Related Issues
flutter/flutter#47153
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?