Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@ditman
Copy link
Member

@ditman ditman commented Mar 12, 2020

Description

JS interop classes do not support non-external constructors, and those fakeConstructor$ were never needed anyway.

A new lint rule discovered this today.

Testing

00:05 +6: All tests passed!

Related Issues

cl/300606170 (internal)

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • No, this is not a breaking change.

ditman added 2 commits March 12, 2020 13:27
@ditman
Copy link
Member Author

ditman commented Mar 12, 2020

Current tree is green. I'm merging this.

@ditman ditman merged commit 6c329d0 into flutter:master Mar 12, 2020
@ditman ditman deleted the google-sign-in-remove-fakeConstructor branch March 12, 2020 21:10
@ditman
Copy link
Member Author

ditman commented Mar 12, 2020

Waiting for post-submit checks to publish plugin.

EdwinRomelta pushed a commit to EdwinRomelta/plugins that referenced this pull request Jun 11, 2020
…tter#2602)

JS interop classes do not support non-external constructors.
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
…tter#2602)

JS interop classes do not support non-external constructors.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants