Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@franciscojma86
Copy link
Contributor

Description

Rename back for backwards compatibility

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@franciscojma86
Copy link
Contributor Author

@ditman So in the end I don't think this is a breaking change since nothing is using the platform interface yet, and it's going back to what it was, so I just did a minor version change. WDYT?

@ditman
Copy link
Member

ditman commented Feb 28, 2020

@ditman So in the end I don't think this is a breaking change since nothing is using the platform interface yet, and it's going back to what it was, so I just did a minor version change. WDYT?

@franciscojma86 yep, every change to this package before it's actually used by the core implementation is minor (there's nothing to break) :P

@franciscojma86 franciscojma86 merged commit 9af7525 into flutter:master Feb 28, 2020
EdwinRomelta pushed a commit to EdwinRomelta/plugins that referenced this pull request Jun 11, 2020
…lutter#2564)

* Rename StorageDirectory

* Update version

* Update version to non-breaking

* Use 1.0.1
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
…lutter#2564)

* Rename StorageDirectory

* Update version

* Update version to non-breaking

* Use 1.0.1
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants