This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Revert "[connectivity_platform_interface] Add ConnectivityResult.unknown."
#2561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collinjackson
approved these changes
Feb 27, 2020
Member
Author
|
(I added a few changes to roll this "back" to 1.0.3+1 (instead of 1.0.3) so this PR can be checked to be fully green when 2.0.0 is removed from pub.dev, otherwise the checks will complain that 1.0.3 is already published after 2.0.0 is gone) |
Change to 1.0.3+1 so this can be merged easily after 2.0.0 is removed.
Document why 1.0.3+1 version was needed (to remove version 2.0.0)
Member
|
|
Member
Author
|
This change will always have a red pre-submit, since the version script checks against |
Contributor
|
OK, sounds good. |
amirh
reviewed
Feb 27, 2020
packages/connectivity/connectivity_platform_interface/CHANGELOG.md
Outdated
Show resolved
Hide resolved
No need to publish a patch bump in this case, this'll land on red regardless.
No need for the patch bump.
amirh
approved these changes
Feb 27, 2020
Member
Author
|
Merging on red, since most of the failures are related to versioning, which is what we're trying to straighten out here. |
EdwinRomelta
pushed a commit
to EdwinRomelta/plugins
that referenced
this pull request
Jun 11, 2020
…nown`." (flutter#2561) The previous push introduced a new major version into the connectivity_platform_interface package. That might not be the best approach. The new version has been unpublished from pub.dev, and this change restores the repo to its previous state. This reverts commit 4411247.
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
…nown`." (flutter#2561) The previous push introduced a new major version into the connectivity_platform_interface package. That might not be the best approach. The new version has been unpublished from pub.dev, and this change restores the repo to its previous state. This reverts commit 4411247.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #2560