This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[path_provider_macos] Adds example app #2559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franciscojma86
changed the title
ditman
reviewed
Feb 26, 2020
packages/path_provider/path_provider_macos/example/test_driver/path_provider_e2e.dart
Outdated
Show resolved
Hide resolved
ditman
reviewed
Feb 27, 2020
packages/path_provider/path_provider_macos/example/test_driver/path_provider_e2e.dart
Outdated
Show resolved
Hide resolved
Member
|
I've seen this error happening in master as well: |
ditman
approved these changes
Feb 27, 2020
Member
ditman
left a comment
ditman
left a comment
There was a problem hiding this comment.
I'm not an expert in _macos, but in general it looks good. The red tests are the same that are currently failing in master. Maybe wait for the tree to go green before merging?
Contributor
Author
|
They passed :) thanks! |
EdwinRomelta
pushed a commit
to EdwinRomelta/plugins
that referenced
this pull request
Jun 11, 2020
* Add macos exmaple * Update version * Fix analyzer * Fix * space * Remove tests * Address comment * Remove show * Import * Add platform * Use right import
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
* Add macos exmaple * Update version * Fix analyzer * Fix * space * Remove tests * Address comment * Remove show * Import * Add platform * Use right import
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a copy of the core plugin's test app, but removed the platform conditions, and just kept the directories supported on macOS.
Related Issues
flutter/flutter#46307
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?