Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@jddeep
Copy link
Contributor

@jddeep jddeep commented Feb 25, 2020

Description

[share] plugin: Update gradle version of example for Android
Fixes [TAG] Warnings and errors caused as generated on Android Studio build terminal while buidling.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

[share] plugin: Update gradle version for Android
Fixes [TAG] Warnings and errors caused as generated on Android Studio build terminal while buidling.
@jddeep jddeep changed the title [share] plugin: Update gradle version for Android [share] plugin: Update gradle version of example for Android Feb 25, 2020
Copy link

@blasten blasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to update the version in pubspec.yaml and changelog.md

@jddeep jddeep requested a review from blasten February 25, 2020 15:48
@jddeep
Copy link
Contributor Author

jddeep commented Feb 25, 2020

@blasten done, have a look please.

Copy link
Contributor

@mklim mklim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing!

@mklim mklim merged commit dad9ea2 into flutter:master Feb 28, 2020
EdwinRomelta pushed a commit to EdwinRomelta/plugins that referenced this pull request Jun 11, 2020
…#2555)

Fixes [TAG] Warnings and errors caused as generated on Android Studio build terminal while buidling.
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
…#2555)

Fixes [TAG] Warnings and errors caused as generated on Android Studio build terminal while buidling.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants