This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[path_provider] Move package into a path_provider directory #2542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@franciscojma86 can you edit the PR description to describe what "First step of federation" is, and how many steps there will be in total? |
ditman
approved these changes
Feb 20, 2020
| name: path_provider | ||
| description: Flutter plugin for getting commonly used locations on the Android & | ||
| iOS file systems, such as the temp and app data directories. | ||
| homepage: https://github.com/flutter/plugins/tree/master/packages/path_provider |
Member
There was a problem hiding this comment.
The homepage also changes, to https://github.com/flutter/plugins/tree/master/packages/path_provider/path_provider
Member
There was a problem hiding this comment.
(you can push this minor change when you come back to this file when doing the federation of _macos, just to conserve your CI/CD luck ;) )
franciscojma86
force-pushed
the
path-interface
branch
from
99d246b to
4f5bcc1
Compare
EdwinRomelta
pushed a commit
to EdwinRomelta/plugins
that referenced
this pull request
Jun 11, 2020
…2542) * Move path provider to dir * Fix example * Add dart file * Rename file * Update homepage link
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
…2542) * Move path provider to dir * Fix example * Add dart file * Rename file * Update homepage link
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First step for federation, as outlined in flutter/flutter#46307 (comment)
Related Issues
flutter/flutter#46307
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?