This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[battery] cleanup for Android embedding post 1.12 #2400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blasten
approved these changes
Dec 11, 2019
| } | ||
|
|
||
| // TODO(amirh): Remove this hack once androidx.lifecycle is included on stable. https://github.com/flutter/flutter/issues/42348 | ||
| afterEvaluate { |
There was a problem hiding this comment.
Should this wait a little longer though to wait for the traffic to ramp up?
Member
Author
There was a problem hiding this comment.
right. Let's not merge this for now. It was just an exercise for us to look at what the new code would look like.
Member
Author
There was a problem hiding this comment.
raised the min sdk version to 1.12. Merging on green.
xster
commented
Dec 11, 2019
| protected void onCreate(Bundle savedInstanceState) { | ||
| super.onCreate(savedInstanceState); | ||
| GeneratedPluginRegistrant.registerWith(this); | ||
| BatteryPlugin.registerWith(registrarFor("io.flutter.plugins.battery.BatteryPlugin")); |
Member
Author
There was a problem hiding this comment.
This part is a bit unfortunate but we built infra to generate for v1 embedding or v2 embedding toggling between v1 and v2 plugins. We never build infra for toggling between v1 and v2 embedding.
This is probably ok since it's mostly transient but we have to document it in flutter/website#3388
collinjackson
changed the title
33 tasks
13 tasks
eugenejeonme
added a commit
to COMANDKEYINC/flutter_plugins
that referenced
this pull request
Dec 19, 2019
* [google_sign_in] Pass the client id to the platform interface. (flutter#2427) The param exists in the platform interface but there was no way to pass anything to clientId through the external interface. * [in_app_purchase]Change a comment. (flutter#2329) * re-enable stable CI (flutter#2402) * [flutter_webview] Raise min Flutter SDK to stable (flutter#2425) v2 embedding apps no longer need to special case their Flutter SDK requirement like they have since v0.3.15+3. * [battery] cleanup for Android embedding post 1.12 (flutter#2400) * [google_sign_in] Expose network error (flutter#2398)
sanekyy
pushed a commit
to sanekyy/plugins
that referenced
this pull request
Dec 21, 2019
hjc22
pushed a commit
to hjc22/plugins
that referenced
this pull request
Jan 8, 2020
…acheing-01-08 * flutterPlugin/master: (30 commits) Update Gradle version (flutter#2448) [image_picker] support android V2 embedding (flutter#2430) [webview_flutter] Setup XCTests (flutter#2445) [video_player] Fixes video initialization future stall. (flutter#2134) [ci] Upgrade to Xcode 11.3 (flutter#2435) [In_app_purchases] migrate to Play Billing Library 2.0. (flutter#2287) Migrate away from deprecated `BinaryMessages` (flutter#2444) [google_sign_in]Update google_sign_in_example name in pubspec.yaml (flutter#2335) [ios_platform_images] Removed android support from the pubspec. (flutter#2432) [google_sign_in] Expose network error (flutter#2398) [battery] cleanup for Android embedding post 1.12 (flutter#2400) [flutter_webview] Raise min Flutter SDK to stable (flutter#2425) re-enable stable CI (flutter#2402) [in_app_purchase]Change a comment. (flutter#2329) [google_sign_in] Pass the client id to the platform interface. (flutter#2427) [ios_platform_images] Made ios_platform_images set the correct image scale. (flutter#2414) [url_launcher_platform_interface] use non static token for platform interface (flutter#2418) [plugin_platform_interface] Don't use const Object as a token (flutter#2417) Update endorsed macos plugins readme and update others (flutter#2407) [webview_flutter] add gesture navigation for iOS (flutter#2339) ... # Conflicts: # packages/video_player/video_player/CHANGELOG.md # packages/video_player/video_player/pubspec.yaml
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I did a clean up on a plugin to look at what it would look like without all the workarounds
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?