[in_app_purchase]Change a comment. #2329
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
mklim
left a comment
mklim
left a comment
There was a problem hiding this comment.
Good catch, thank you for the contribution!
Could you also update the plugin's version in the pubspec.yaml and add a line for this change in CHANGELOG.md? That way we can publish this fix to pub.dev.
Update from original.
|
Thanks again for the fix! |
* [google_sign_in] Pass the client id to the platform interface. (flutter#2427) The param exists in the platform interface but there was no way to pass anything to clientId through the external interface. * [in_app_purchase]Change a comment. (flutter#2329) * re-enable stable CI (flutter#2402) * [flutter_webview] Raise min Flutter SDK to stable (flutter#2425) v2 embedding apps no longer need to special case their Flutter SDK requirement like they have since v0.3.15+3. * [battery] cleanup for Android embedding post 1.12 (flutter#2400) * [google_sign_in] Expose network error (flutter#2398)
|
@mklim Not sure the best place to ask, but can the new versions be published (0.2.2+5/0.2.2+6) to pub.dev (or what's the release cycle) as I need the fix from 0.2.2+5 |
|
@droidery sorry about the delay there, thanks for the ping. The release process is totally manual and it looks like we missed publishing those PRs (flutter/flutter#27258). They should be available now. |
…acheing-01-08 * flutterPlugin/master: (30 commits) Update Gradle version (flutter#2448) [image_picker] support android V2 embedding (flutter#2430) [webview_flutter] Setup XCTests (flutter#2445) [video_player] Fixes video initialization future stall. (flutter#2134) [ci] Upgrade to Xcode 11.3 (flutter#2435) [In_app_purchases] migrate to Play Billing Library 2.0. (flutter#2287) Migrate away from deprecated `BinaryMessages` (flutter#2444) [google_sign_in]Update google_sign_in_example name in pubspec.yaml (flutter#2335) [ios_platform_images] Removed android support from the pubspec. (flutter#2432) [google_sign_in] Expose network error (flutter#2398) [battery] cleanup for Android embedding post 1.12 (flutter#2400) [flutter_webview] Raise min Flutter SDK to stable (flutter#2425) re-enable stable CI (flutter#2402) [in_app_purchase]Change a comment. (flutter#2329) [google_sign_in] Pass the client id to the platform interface. (flutter#2427) [ios_platform_images] Made ios_platform_images set the correct image scale. (flutter#2414) [url_launcher_platform_interface] use non static token for platform interface (flutter#2418) [plugin_platform_interface] Don't use const Object as a token (flutter#2417) Update endorsed macos plugins readme and update others (flutter#2407) [webview_flutter] add gesture navigation for iOS (flutter#2339) ... # Conflicts: # packages/video_player/video_player/CHANGELOG.md # packages/video_player/video_player/pubspec.yaml
4 participants
Description
Change a comment.