Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@ditman
Copy link
Member

@ditman ditman commented Nov 26, 2019

Description

This is a continuation of #2316

This PR adds the google_sign_in_web plugin to the exclusion list of the darwin lint script.

Related Issues

flutter/flutter#45571

See also:

#2177

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

Add google_sign_in_web to lint_darwin_plugins.sh so its dummy podspec
isn't validated.
@ditman ditman requested a review from jmagman November 26, 2019 22:56
@ditman ditman changed the title Issues/45571 darwin lint fix [script] Exclude google_sign_in_web from podspec lint. Nov 26, 2019
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@jmagman
Copy link
Member

jmagman commented Nov 27, 2019

Unless you want to revert the podspec change since you would need a silly CHANGELOG entry?

@ditman ditman force-pushed the issues/45571-darwin-lint-fix branch from 177b546 to 86ca80f Compare November 27, 2019 00:28
@ditman
Copy link
Member Author

ditman commented Nov 27, 2019

Unless you want to revert the podspec change since you would need a silly CHANGELOG entry?

(@jmagman I ended up removing it from the PR by force-pushing without it.)

@ditman ditman merged commit 330a3e0 into flutter:master Nov 27, 2019
sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request Dec 17, 2019
Add google_sign_in_web to lint_darwin_plugins.sh so its dummy podspec isn't validated.
@ditman ditman deleted the issues/45571-darwin-lint-fix branch May 21, 2020 18:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants