Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[google_sign_in_web] Add empty podspec to plugin. #2316

Merged
ditman merged 1 commit into from
Nov 26, 2019
Merged

[google_sign_in_web] Add empty podspec to plugin. #2316

ditman merged 1 commit into from
Nov 26, 2019

Conversation

@ditman
Copy link
Member

@ditman ditman commented Nov 26, 2019

Description

Add an empty podspec file, so this plugin doesn't break compilation on IOS.

Similar to this.

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@harryterkelsen
Copy link
Contributor

harryterkelsen commented Nov 26, 2019

Is there a tracking issue for not breaking iOS compilation when plugins don't have a Podspec?

@ditman
Copy link
Member Author

ditman commented Nov 26, 2019 •
edited
Loading

Is there a tracking issue for not breaking iOS compilation when plugins don't have a Podspec?

@hterkelsen I thought this wasn't needed anymore. I am not aware of a tracking issue. Looking at this, it seems that maybe there's extra work that needs to be done in addition to adding a fake podspec in the plugin?

#2177

/cc @mklim

@ditman ditman merged commit 2d15096 into flutter:master Nov 26, 2019
@ditman ditman deleted the issues/45571 branch November 26, 2019 22:12
@mklim
Copy link
Contributor

mklim commented Nov 26, 2019

Is there a tracking issue for not breaking iOS compilation when plugins don't have a Podspec?

@hterkelsen I thought this wasn't needed anymore. I am not aware of a tracking issue. Looking at this, it seems that maybe there's extra work that needs to be done in addition to adding a fake podspec in the plugin?

#2177

/cc @mklim

I'm not up to date with this, sorry. @jmagman, do you know?

@jmagman
Copy link
Member

jmagman commented Nov 26, 2019

pod lint runs on pre-submit for any edited or new podspecs (see https://cirrus-ci.com/task/4992659592052736). If you want to skip the lint for a podspec, like a place-holder one, you should add it to the skipped_podspecs list https://github.com/flutter/plugins/blob/master/script/lint_darwin_plugins.sh#L18

@jmagman
Copy link
Member

jmagman commented Nov 26, 2019

Was this merged before all the presubmit checks passed? Or was lint_darwin_plugins actually passing? @ditman

@ditman
Copy link
Member Author

ditman commented Nov 26, 2019

@jmagman it was indeed merged before the lint passed, my bad! I found out about the check after clicking merge :/

@jmagman
Copy link
Member

jmagman commented Nov 26, 2019

@ditman Can you add it to the list in the script in a new PR? You can test it by changing something in that plugin and running the script locally. The next person who edits this plugin will fail that lint.

@ditman
Copy link
Member Author

ditman commented Nov 26, 2019

@jmagman on it, thanks!

@ditman ditman mentioned this pull request Nov 26, 2019
Merged
13 tasks
sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request Dec 17, 2019
@ditman
[google_sign_in_web] Add empty podspec to plugin. (flutter#2316)
8590079 
Add an empty podspec file, so this plugin doesn't break compilation on IOS.

This should fix flutter/flutter#45571
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mklim mklim Awaiting requested review from mklim

1 more reviewer

@harryterkelsen harryterkelsen harryterkelsen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ditman @harryterkelsen @mklim @jmagman @googlebot