Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[camera] Fix unawaited future errors #2312

Merged
mklim merged 1 commit into from
Nov 26, 2019
Merged

[camera] Fix unawaited future errors #2312

mklim merged 1 commit into from
Nov 26, 2019

Conversation

@mklim
Copy link
Contributor

@mklim mklim commented Nov 26, 2019 •
edited
Loading

Description

There's a over a dozen API surfaces that are undocumented still. This
just fixes one of the new pedantic lints.

Related Issues

flutter/flutter#45440

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

[camera] Fix unawaited future errors
4e53be3 
There's a over a dozen API surfaces that are undocumented still. This
just fixes one of the new pedantic lints.
@mklim mklim requested a review from bparrishMines November 26, 2019 20:30
bparrishMines
bparrishMines approved these changes Nov 26, 2019
View reviewed changes
Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mklim mklim merged commit 948744e into flutter:master Nov 26, 2019
@mklim mklim deleted the camera_fixup branch November 26, 2019 22:49
sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request Dec 17, 2019
[camera] Fix unawaited future errors (flutter#2312)
33920ec 
There's a over a dozen API surfaces that are undocumented still. This
just fixes one of the new pedantic lints.
Akachu pushed a commit to Akachu/flutter_camera that referenced this pull request Apr 27, 2020
[camera] Fix unawaited future errors (flutter#2312)
4bfe492 
There's a over a dozen API surfaces that are undocumented still. This
just fixes one of the new pedantic lints.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@bparrishMines bparrishMines bparrishMines approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mklim @bparrishMines @googlebot