This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[url_launcher] Update deps and docs in url_launcher_web #2289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ditman
commented
Nov 19, 2019
harryterkelsen
approved these changes
Nov 19, 2019
Member
Author
|
I'll land this when it checks go green |
| sdk: flutter | ||
| url_launcher: | ||
| path: ../url_launcher | ||
| url_launcher: ^5.2.5 |
There was a problem hiding this comment.
Does 5.2.5 work with web? The build dashboard had to do a manual set to get it working again (see flutter/cocoon#517)
Member
Author
There was a problem hiding this comment.
I've looked at the errors that prompted your change, and it seems that you attempted to use this package (too) early on, when it still used Method Channels. The most current implementations of this plugin and url_launcher shouldn't use method channels in the browser, and instead use the platform interface. Please, give this version of the plugin a shot when it gets published!
There was a problem hiding this comment.
Thanks David! I opened a PR to update the build dashboard back to using the latest then :)
sungmin-park
pushed a commit
to sungmin-park/flutter-plugins
that referenced
this pull request
Dec 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated dependencies and docs in the package so it can be usable from pub.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?