Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@xster
Copy link
Member

@xster xster commented Nov 16, 2019

Description

Add v2 support for path_provider with Aaron's script

Related Issues

Fixes flutter/flutter#41844

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@xster xster requested a review from collinjackson as a code owner November 16, 2019 01:14
@xster xster changed the title Add v2 embedding support for path_provider [path_provider] Add v2 embedding support for Nov 16, 2019
@xster xster requested a review from gaaclarke November 16, 2019 01:33
Copy link
Contributor

@collinjackson collinjackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@doneason1983
Copy link

Hey

@xster xster merged commit dc48e70 into flutter:master Nov 22, 2019
@xster xster deleted the path-provider branch November 22, 2019 00:08
sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request Dec 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[path_provider] Support the v2 Android embedder plugins API

4 participants