Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[video_player] Use platform interface #2276

Merged
harryterkelsen merged 9 commits into from
Nov 28, 2019
Merged

[video_player] Use platform interface #2276

harryterkelsen merged 9 commits into from
Nov 28, 2019

Conversation

@cbenhagen
Copy link
Contributor

@cbenhagen cbenhagen commented Nov 13, 2019

Description

Second part of #2273

Related Issues

#2041

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

This was referenced Nov 13, 2019
Closed
Merged
@cbenhagen cbenhagen changed the title [video_player] Use platform interface [video_player] [WIP] Use platform interface Nov 13, 2019
@cbenhagen cbenhagen force-pushed the video-player-platform-interface-part2 branch 4 times, most recently from 2d20034 to 1da000a Compare November 14, 2019 12:32
cbenhagen
cbenhagen commented Nov 14, 2019
View reviewed changes
@cbenhagen cbenhagen force-pushed the video-player-platform-interface-part2 branch 3 times, most recently from e4595b6 to 2ab4c98 Compare November 21, 2019 23:25
@cbenhagen cbenhagen force-pushed the video-player-platform-interface-part2 branch from 2ab4c98 to 677bf29 Compare November 21, 2019 23:54
@cbenhagen
Copy link
Contributor Author

cbenhagen commented Nov 22, 2019

@hterkelsen I cleaned up this PR and moved 2 tests I missed in the last merge of part 1.

@cbenhagen cbenhagen changed the title [video_player] [WIP] Use platform interface [video_player] Use platform interface Nov 22, 2019
@cbenhagen
Merge branch 'master' into video-player-platform-interface-part2
752ac35 
# Conflicts:
#	packages/video_player/video_player/CHANGELOG.md
#	packages/video_player/video_player/lib/video_player.dart
#	packages/video_player/video_player/pubspec.yaml
@cbenhagen
Merge master
d538948
harryterkelsen
harryterkelsen suggested changes Nov 23, 2019
View reviewed changes
Copy link
Contributor

@harryterkelsen harryterkelsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please export the types in package:video_player

@dream-1ab
Copy link

dream-1ab commented Nov 24, 2019 •
edited
Loading

Hello, how can I create a new 'pull request' on this project?
now I'm making a movies app using flutter,
I want to encode/decode movie segments in memory using my own algorithm and play it with video_player plugin, but I can't find like 'VideoPlayerController.memory' method.

now video_player supported only play from asset, local file, network,
it's not provide play video from memory source (UInt8List, List...)
I have some Android kotlin development experience and server side development with kotlin etc, but I have no any IOS/macOS development experience with obj-c/Swift and I have no any apple development environment (macOS, Ios devices),
can possible to provide play movie from memory source (e.g. UInt8List) as will?
thank you.

harryterkelsen
harryterkelsen suggested changes Nov 25, 2019
View reviewed changes
Copy link
Contributor

@harryterkelsen harryterkelsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed this before, but you also need to export VideoFormat. In the meantime, I will upload video_player_platform_interface to pub to get the tests running

@cbenhagen
Copy link
Contributor Author

cbenhagen commented Nov 25, 2019

VideoFormat is now being exported as well. Thanks for publishing the platform interface.

@cbenhagen
Copy link
Contributor Author

cbenhagen commented Nov 25, 2019

@hterkelsen Sorry, I made mistake in the platform interface. This now depends on #2305.

@harryterkelsen
Copy link
Contributor

harryterkelsen commented Nov 26, 2019

I just published video_player_platform_interface 1.0.1 to pub. You should be able to depend on it in your pubspec now and hopefully get the tests passing.

@cbenhagen
Copy link
Contributor Author

cbenhagen commented Nov 26, 2019

Thanks! Yes I already changed the pubspec. Can you restart the checks for me please?

@cbenhagen
Copy link
Contributor Author

cbenhagen commented Nov 27, 2019 •
edited
Loading

Yay all checks have passed :) It still shows that there are requested changes from you Harry. Is there anything I missed or has this been resolved by exporting DurationRange, DataSourceType and VideoFormat?

Btw is there any way to speedup those tests? They sometimes take more than 10h.

@harryterkelsen
Copy link
Contributor

harryterkelsen commented Nov 27, 2019

LGTM. Yeah the tests take a long time because we are throttled on the number of mac instances we can test on.

@harryterkelsen harryterkelsen merged commit 3d57cff into flutter:master Nov 28, 2019
sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request Dec 17, 2019
@cbenhagen
[video_player] Use platform interface (flutter#2276)
9187c85 
* [video_player] Use platform interface

* Move tests (leftover from part1)

* Merge master

* Export DurationRange and DataSourceType

* Export VideoFormat

* ignore: unused_element

* Format

* Update video_player_platform_interface dependency
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

@iskakaushik iskakaushik Awaiting requested review from iskakaushik

@collinjackson collinjackson Awaiting requested review from collinjackson

1 more reviewer

@harryterkelsen harryterkelsen harryterkelsen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cbenhagen @dream-1ab @harryterkelsen @googlebot