This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Run the publish with the pub version from flutter stable #2250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amirh
force-pushed
the
publish_check_stable
branch
from
338017e to
cbf8147
Compare
mklim
reviewed
Nov 1, 2019
amirh
force-pushed
the
publish_check_stable
branch
from
cbf8147 to
4d2f19a
Compare
amirh
force-pushed
the
publish_check_stable
branch
from
4d2f19a to
f738969
Compare
eugenejeonme
added a commit
to COMANDKEYINC/flutter_plugins
that referenced
this pull request
Nov 6, 2019
…tter#2250)" This reverts commit 451a689.
mormih
pushed a commit
to mormih/plugins
that referenced
this pull request
Nov 17, 2019
sungmin-park
pushed a commit
to sungmin-park/flutter-plugins
that referenced
this pull request
Dec 17, 2019
Contributor
|
@amirh Why did we decide not to run publish with master? |
Contributor
|
@cyanglaz at the time this PR was merged master had publish warnings that we were failing, if I remember correctly because of the new federated plugin format. Also if I remember correctly there wasn't a way to satisfy the warnings and also stay backwards compatible with stable. Since there's been a new stable roll relatively recently I don't think this still applies, but not 100% sure. |
Contributor
|
@mklim Thanks!I would like to confirm that and bring back the publish check on master. I guess you are right, I have a vague memory of this too. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.