This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[url_launcher] Migrate url_launcher_web to the platform interface #2237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hmm it seems the version check test is failing because the cirrus script is deleting all |
Contributor
|
Mmm we cant land as CI will be red and block others. File an issue and we
need to fix it before landing
…On Fri, Oct 25, 2019 at 4:42 PM Harry Terkelsen ***@***.***> wrote:
Hmm it seems the version check test is failing because the cirrus script
is deleting all _web$ directories, and it fails when trying to read the
changed pubspec. Should I file an issue and land this PR?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2237?email_source=notifications&email_token=AAH2A5OR3IZANW5D3W263X3QQN77HA5CNFSM4JFKCCS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECJZ7CI#issuecomment-546545545>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAH2A5LOQZQL3CSJ6R2E3LTQQN77HANCNFSM4JFKCCSQ>
.
|
Contributor
|
@hterkelsen I re-ran your tests now that https://github.com/flutter/plugin_tools/pull/63 has been published. You should be able to land this now. |
mormih
pushed a commit
to mormih/plugins
that referenced
this pull request
Nov 17, 2019
…utter#2237) * [url_launcher] Migrate url_launcher_web to the platform interface * Fix analyzer errors * Add doc comments
sungmin-park
pushed a commit
to sungmin-park/flutter-plugins
that referenced
this pull request
Dec 17, 2019
…utter#2237) * [url_launcher] Migrate url_launcher_web to the platform interface * Fix analyzer errors * Add doc comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate
url_launcher_webto use the platform interface instead ofMethodChannel.Related Issues
None.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?