Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@mklim
Copy link
Contributor

@mklim mklim commented Oct 18, 2019

There was a recent contributor who was blocked on trying to run the Java unit tests, since they're not clearly documented anywhere.

Copy link
Contributor

@amirh amirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo nits

@collinjackson collinjackson merged commit 95594f5 into flutter:master Nov 22, 2019
@mklim mklim deleted the fix_contributing branch November 22, 2019 01:43
@mklim
Copy link
Contributor Author

mklim commented Nov 22, 2019

Whoops, forgot to circle back to this. Thanks for merging!

sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request Dec 17, 2019
* Fix testing instructions in CONTRIBUTING.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants