Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[connectivity]remove AndroidX constraint #2212

Merged
cyanglaz merged 10 commits into from
Oct 18, 2019
Merged

[connectivity]remove AndroidX constraint #2212

cyanglaz merged 10 commits into from
Oct 18, 2019

Conversation

@cyanglaz
Copy link
Contributor

@cyanglaz cyanglaz commented Oct 18, 2019 •
edited
Loading

Description

After 0.4.5, we introduced a constraint that the app uses the plugin has to be migrated to androidx.
This patch removes the constraint.

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@cyanglaz
Copy link
Contributor Author

cyanglaz commented Oct 18, 2019

@blasten I did what you suggested to remove the androidX constraint but it seems to be failing on stable now. Do you have any idea?

@cyanglaz cyanglaz requested a review from blasten October 18, 2019 03:45
Chris Yang added 2 commits October 17, 2019 22:03
@cyanglaz cyanglaz requested review from blasten and removed request for blasten October 18, 2019 05:04
@cyanglaz cyanglaz mentioned this pull request Oct 18, 2019
Closed
mklim
mklim approved these changes Oct 18, 2019
View reviewed changes
Copy link
Contributor

@mklim mklim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyanglaz cyanglaz merged commit a79b89c into flutter:master Oct 18, 2019
@cyanglaz cyanglaz deleted the connectivity_remove_androidx branch October 18, 2019 22:32
mormih pushed a commit to mormih/plugins that referenced this pull request Nov 17, 2019
@mormih
[connectivity]remove AndroidX constraint (flutter#2212)
15ce322 
After 0.4.5, we introduced a constraint that the app uses the plugin has to be migrated to androidx.
This patch removes the constraint.
sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request Dec 17, 2019
[connectivity]remove AndroidX constraint (flutter#2212)
c0dd0ba 
After 0.4.5, we introduced a constraint that the app uses the plugin has to be migrated to androidx.
This patch removes the constraint.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@blasten blasten Awaiting requested review from blasten

2 more reviewers

@collinjackson collinjackson collinjackson approved these changes

@mklim mklim mklim approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cyanglaz @collinjackson @mklim @googlebot