[webview_flutter] (Trivial) Add V2 warnings #2196
Conversation
The V2 embedding in webview_flutter depends on an extremely new bugfix in flutter/engine. This was mentioned in the git log but that's difficult to find. Add more warnings in the docs surrounding the new code path. In general this is an interesting problem. We can't select for the higher version as a min SDK requirement because the old embedding path doesn't need this bugfix. Ideally we should figure out a way to programmatically enforce this constraint instead of relying on developer documentation. This kind of problem is likely to happen again.
|
Hi Sir! |
|
Seems like we've used an engine Java method that's not available on stable :( I feel like we should wait for this to be available on master before adding it to the plugin. My suggestion would be to revert this change and re-publish a v1 only version. Alternatively we could consider using reflection to access this method, but this is getting dirtier... |
|
@lbsfei thanks for the bug report! @amirh looks like that method rolled in v1.8.1. flutter/flutter@763ce63, flutter/engine#9206, which is below the latest stable. The problem here looks like the plugin is set to require something lower than the latest stable in its pubspec.yaml, |
|
@mklim make sense. |
The V2 embedding in webview_flutter depends on an extremely new bugfix in flutter/engine. This was mentioned in the git log but that's difficult to find. Add more warnings in the docs surrounding the new code path. In general this is an interesting problem. We can't select for the higher version as a min SDK requirement because the old embedding path doesn't need this bugfix. Ideally we should figure out a way to programmatically enforce this constraint instead of relying on developer documentation. This kind of problem is likely to happen again.
The V2 embedding in webview_flutter depends on an extremely new bugfix in flutter/engine. This was mentioned in the git log but that's difficult to find. Add more warnings in the docs surrounding the new code path. In general this is an interesting problem. We can't select for the higher version as a min SDK requirement because the old embedding path doesn't need this bugfix. Ideally we should figure out a way to programmatically enforce this constraint instead of relying on developer documentation. This kind of problem is likely to happen again.
5 participants
Description
The V2 embedding in webview_flutter depends on an extremely new bugfix
in flutter/engine. This was mentioned in the git log but that's
difficult to find. Add more warnings in the docs surrounding the new
code path.
In general this is an interesting problem. We can't select for the
higher version as a min SDK requirement because the old embedding path
doesn't need this bugfix. Ideally we should figure out a way to
programmatically enforce this constraint instead of relying on developer
documentation. This kind of problem is likely to happen again.
Related Issues
flutter/flutter#41851
flutter/engine#13015
flutter/flutter#42792
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
/cc @matthew-carroll