Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@collinjackson
Copy link
Contributor

@collinjackson collinjackson commented Oct 15, 2019

Required in order to end-to-end test migrated plugins.

@collinjackson collinjackson changed the title Update to support new embedder [e2e] Update to support new embedder Oct 15, 2019
@collinjackson collinjackson requested a review from mklim October 15, 2019 00:32
Copy link
Contributor

@mklim mklim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@collinjackson
Copy link
Contributor Author

Yes, I've updated the example app, this plugin can actually e2e test itself.

Copy link
Contributor

@mklim mklim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat, thanks! LGTM

@collinjackson collinjackson merged commit f7297f5 into flutter:master Oct 15, 2019
mormih pushed a commit to mormih/plugins that referenced this pull request Nov 17, 2019
* Support the v2 Android embedder.
* Print a warning if the plugin is not registered.	
* Updated method channel name.
* Set a Flutter minimum SDK version.
sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request Dec 17, 2019
* Support the v2 Android embedder.
* Print a warning if the plugin is not registered.	
* Updated method channel name.
* Set a Flutter minimum SDK version.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants