Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[battery] relax the example app minimal required Flutter version #2189

Merged
amirh merged 2 commits into from
Oct 14, 2019
Merged

[battery] relax the example app minimal required Flutter version #2189

amirh merged 2 commits into from
Oct 14, 2019

Conversation

@amirh
Copy link
Contributor

@amirh amirh commented Oct 14, 2019

Description

The v1 embedder Activity can actually work with 1.6.7

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

mklim
mklim approved these changes Oct 14, 2019
View reviewed changes
Copy link
Contributor

@mklim mklim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/battery/example/pubspec.yaml Outdated

environment:
flutter: ">=1.9.1+hotfix.4 <2.0.0"
flutter: ">=1.6.7 <2.0.0"
Copy link
Contributor

@mklim mklim Oct 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Does this match the wider pubspec? It may be easier to just delete this entirely.

Copy link
Contributor Author

@amirh amirh Oct 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, removed.

@amirh amirh merged commit 3a77d38 into flutter:master Oct 14, 2019
@amirh amirh deleted the relax_battery_example branch October 14, 2019 23:23
mormih pushed a commit to mormih/plugins that referenced this pull request Nov 17, 2019
@amirh @mormih
[battery] relax the example app minimal required Flutter version (flu…
e9b6552 
…tter#2189)
sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request Dec 17, 2019
@amirh
[battery] relax the example app minimal required Flutter version (flu…
fbc9d67 
…tter#2189)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@mklim mklim mklim approved these changes

@matthew-carroll matthew-carroll matthew-carroll approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@amirh @mklim @matthew-carroll @googlebot