Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[android_intent] Bump the Flutter SDK min version #2188

Merged
mklim merged 1 commit into from
Oct 14, 2019
Merged

[android_intent] Bump the Flutter SDK min version #2188

mklim merged 1 commit into from
Oct 14, 2019

Conversation

@mklim
Copy link
Contributor

@mklim mklim commented Oct 14, 2019 •
edited
Loading

Description

The previous minimum was too low to support the V2 embedding at compile
time.

Related Issues

flutter/flutter#41831

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@mklim mklim requested review from amirh and cyanglaz October 14, 2019 19:13
[android_intent] Bump the Flutter SDK min version
1a06763 
The previous minimum was too low to support the V2 embedding at compile
time. The latest stable appears to be the oldest version that works with
the plugin.
amirh
amirh approved these changes Oct 14, 2019
View reviewed changes
Copy link
Contributor

@amirh amirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mklim
Copy link
Contributor Author

mklim commented Oct 14, 2019

I'm ignoring the analyzer failure and landing this with red checks because the lack of pubspec increment is deliberate.

@mklim mklim merged commit 63d0571 into flutter:master Oct 14, 2019
@mklim mklim deleted the android_intent_pubspec branch October 14, 2019 20:58
mormih pushed a commit to mormih/plugins that referenced this pull request Nov 17, 2019
@mormih
[android_intent] Bump the Flutter SDK min version (flutter#2188)
840f17b 
The previous minimum was too low to support the V2 embedding at compile
time. The latest stable appears to be the oldest version that works with
the plugin.
sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request Dec 17, 2019
[android_intent] Bump the Flutter SDK min version (flutter#2188)
9268649 
The previous minimum was too low to support the V2 embedding at compile
time. The latest stable appears to be the oldest version that works with
the plugin.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

1 more reviewer

@amirh amirh amirh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mklim @amirh @googlebot