This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[url_launcher] Enable androidx and jetifier in android gradle properties #2174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zazo032
reviewed
Oct 14, 2019
Comment on lines
+2
to
+3
| android.useAndroidX=true | ||
| android.enableJetifier=true |
Contributor
There was a problem hiding this comment.
Should this two lines also be added to example/android/gradle.properties file? Also, as added to that file, should R8 be enabled here too?
(sorry if it's too late)
mormih
pushed a commit
to mormih/plugins
that referenced
this pull request
Nov 17, 2019
sungmin-park
pushed a commit
to sungmin-park/flutter-plugins
that referenced
this pull request
Dec 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes bug where androidx app (e.g.
firebase_dynamic_links) won't build with this plugin by enabling androidx and jetifier in the androidgradle.properties.This PR fixes the failing test in the flutterfire repo where the
firebase_dynamic_linksexample app won't build. Thefirebase_dynamic_linksplugin uses androidx and this plugin needs to support the use case.https://cirrus-ci.com/task/5767379681804288
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?