[shared_preferences] Support v2 android embedder. #2162

cyanglaz · 2019-10-07T17:35:22Z

Description

Migrate shared_preferences to the new android embedding. This PR does the minimum work to migrate the plugin to the 2.0 embedder. No additional refactoring and tests are added.

Note: IAP migration is depended on landing this PR.

Related Issues

flutter/flutter#41848

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
No, this is not a breaking change.

bparrishMines

LGTM with gradle snippet: https://gist.github.com/blasten/78e97b1d97a736d7e8dcc3f520cea3f0

...nces/android/src/main/java/io/flutter/plugins/sharedpreferences/SharedPreferencesPlugin.java

…lugins/sharedpreferences/SharedPreferencesPlugin.java Co-Authored-By: Maurice Parrish <[email protected]>

googlebot · 2019-10-11T21:13:29Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot · 2019-10-11T21:41:55Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

matthew-carroll

LGTM from a new plugin API perspective.

matthew-carroll · 2019-10-11T22:08:35Z

...nces/android/src/main/java/io/flutter/plugins/sharedpreferences/SharedPreferencesPlugin.java

-    }.execute();
+  @Override
+  public void onDetachedFromEngine(@NonNull FlutterPlugin.FlutterPluginBinding binding) {
+    channel.setMethodCallHandler(null);


Recommendation: Consider defining a teardownChannel() for symmetry with setupChannel().

matthew-carroll · 2019-10-11T22:08:49Z

packages/shared_preferences/example/android/app/src/main/AndroidManifest.xml

                  android:windowSoftInputMode="adjustResize">
+        </activity>
+        <activity android:name=".MainActivity"
+            android:launchMode="singleTop"


I made a comment about singleTop in the sensor PR.

googlebot · 2019-10-14T16:20:26Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

matthew-carroll · 2019-10-21T20:59:50Z

LGTM

googlebot · 2019-10-21T21:00:43Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

googlebot · 2019-10-21T21:05:57Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot · 2019-10-21T21:06:13Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

…s into migrate_share_preference

googlebot · 2019-10-21T21:21:31Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot · 2019-10-21T23:59:57Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

migrate

4f634a0

googlebot added the cla: yes label Oct 7, 2019

Chris Yang added 5 commits October 7, 2019 11:53

add lisence header

08d5d6c

remove new package

69ab237

refactor

5791375

rename activies

96fc2f4

non public

12fb87d

bparrishMines approved these changes Oct 10, 2019

View reviewed changes

...nces/android/src/main/java/io/flutter/plugins/sharedpreferences/SharedPreferencesPlugin.java Outdated Show resolved Hide resolved

Chris Yang and others added 2 commits October 11, 2019 13:57

fix gradle

ea68abf

Update packages/shared_preferences/android/src/main/java/io/flutter/p…

b50066b

…lugins/sharedpreferences/SharedPreferencesPlugin.java Co-Authored-By: Maurice Parrish <[email protected]>

googlebot added cla: no and removed cla: yes labels Oct 11, 2019

cyanglaz requested a review from matthew-carroll October 11, 2019 21:41

cyanglaz added cla: yes and removed cla: no labels Oct 11, 2019

matthew-carroll approved these changes Oct 11, 2019

View reviewed changes

review fixes

a37694b

googlebot added cla: no and removed cla: yes labels Oct 14, 2019

cyanglaz changed the title ~~[shared_preferences] migrate to the new android embedding~~ [shared_preferences] Support v2 android embedder. Oct 15, 2019

Chris Yang added 2 commits October 15, 2019 16:10

Update MainActivity.java

53bea3f

add e2e tests

0193360

cyanglaz requested a review from collinjackson as a code owner October 15, 2019 23:35

remove androidx

7c6c059

cyanglaz added cla: yes and removed cla: no labels Oct 21, 2019

Merge branch 'master' into migrate_share_preference

48453f2

googlebot added cla: no and removed cla: yes labels Oct 21, 2019

cyanglaz added cla: yes and removed cla: no labels Oct 21, 2019

Chris Yang added 2 commits October 21, 2019 14:21

remove unused driver test

ee4389f

Merge branch 'migrate_share_preference' of github.com:cyanglaz/plugin…

907a6fc

…s into migrate_share_preference

googlebot added cla: no and removed cla: yes labels Oct 21, 2019

cyanglaz added cla: yes and removed cla: no labels Oct 21, 2019

cyanglaz merged commit fe9b559 into flutter:master Oct 22, 2019

cyanglaz deleted the migrate_share_preference branch October 22, 2019 00:00

mormih pushed a commit to mormih/plugins that referenced this pull request Nov 17, 2019

[shared_preferences] Support v2 android embedding. (flutter#2162)

1858a99

sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request Dec 17, 2019

[shared_preferences] Support v2 android embedding. (flutter#2162)

30601c5

[shared_preferences] Support v2 android embedder. #2162

[shared_preferences] Support v2 android embedder. #2162

Uh oh!

Conversation

cyanglaz commented Oct 7, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Checklist

Breaking Change

Uh oh!

bparrishMines left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

googlebot commented Oct 11, 2019

Uh oh!

googlebot commented Oct 11, 2019

Uh oh!

matthew-carroll left a comment

Choose a reason for hiding this comment

Uh oh!

matthew-carroll Oct 11, 2019

Choose a reason for hiding this comment

Uh oh!

matthew-carroll Oct 11, 2019

Choose a reason for hiding this comment

Uh oh!

googlebot commented Oct 14, 2019

Uh oh!

matthew-carroll commented Oct 21, 2019

Uh oh!

googlebot commented Oct 21, 2019

Uh oh!

googlebot commented Oct 21, 2019

Uh oh!

googlebot commented Oct 21, 2019

Uh oh!

googlebot commented Oct 21, 2019

Uh oh!

googlebot commented Oct 21, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

cyanglaz commented Oct 7, 2019 •

edited

Loading