This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[Share] Support v2 android embedder. #2156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 4, 2019 13:44
12 tasks
matthew-carroll
approved these changes
Oct 11, 2019
Contributor
matthew-carroll
left a comment
matthew-carroll
left a comment
There was a problem hiding this comment.
LGTM from a new plugin API perspective.
| } | ||
|
|
||
| @Override | ||
| public void onDetachedFromEngine(FlutterPluginBinding binding) {} |
Contributor
There was a problem hiding this comment.
Should we teardown the channel here?
| } | ||
| private void setUpChannel(BinaryMessenger messenger) { | ||
| methodChannel = new MethodChannel(messenger, CHANNEL); | ||
| share = new Share(activity); |
Contributor
There was a problem hiding this comment.
It looks like activity is always null at this point. You can probably remove the local activity variable and exclusively use the setter method, instead.
| <application android:name="io.flutter.app.FlutterApplication" android:label="share_example" android:icon="@mipmap/ic_launcher"> | ||
| <activity android:name=".MainActivity" | ||
| <activity android:name=".EmbeddingV1Activity" | ||
| android:launchMode="singleTop" |
Contributor
There was a problem hiding this comment.
I made a comment about singleTop in the sensor PR.
Contributor
Author
|
@matthew-carroll Updated based on your last review suggestions. |
Contributor
|
Thanks. Still LGTM! |
cyanglaz
changed the title
packages/share/pubspec.yaml
Outdated
| environment: | ||
| sdk: ">=2.0.0-dev.28.0 <3.0.0" | ||
| flutter: ">=1.6.7 <2.0.0" | ||
| flutter: ">=1.9.1+hotfix.2 <2.0.0" |
Contributor
There was a problem hiding this comment.
Does the share plugin really require such a recent version?
matthew-carroll
approved these changes
Oct 21, 2019
mormih
pushed a commit
to mormih/plugins
that referenced
this pull request
Nov 17, 2019
sungmin-park
pushed a commit
to sungmin-park/flutter-plugins
that referenced
this pull request
Dec 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate to the new android embedding.
Related Issues
flutter/flutter#41847
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?