This repository was archived by the owner on Feb 22, 2023. It is now read-only.
BugFix: formatHint was meant for network streams.
#2141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amirh
reviewed
Oct 4, 2019
Contributor
amirh
left a comment
amirh
left a comment
There was a problem hiding this comment.
Fix looks good, we need a test before we can land
Member
Author
You have no testing infrastructure for that entire class. |
TytaniumDev
reviewed
Oct 4, 2019
This hint is only valid in the network path.
jtmcdole
force-pushed
the
fixFormatHint
branch
from
11c4eb4 to
f0b6494
Compare
mormih
pushed a commit
to mormih/plugins
that referenced
this pull request
Nov 17, 2019
This hint is only valid in the network path.
sungmin-park
pushed a commit
to sungmin-park/flutter-plugins
that referenced
this pull request
Dec 17, 2019
This hint is only valid in the network path.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hint is only valid in the network path.