This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[image_picker] fix crash when aar from 'flutter build aar' #2120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Why this task still running |
cyanglaz
reviewed
Oct 1, 2019
Contributor
cyanglaz
left a comment
cyanglaz
left a comment
There was a problem hiding this comment.
The fix LGTM! Can we add some tests for this change?
Contributor
Author
done. |
cyanglaz
approved these changes
Oct 2, 2019
.../example/android/app/src/test/java/io/flutter/plugins/imagepicker/ImagePickerPluginTest.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Hi @cyanglaz ,Can I know what else I need to do to help the PR merge into the master branch? |
Contributor
|
@liujingtech Could you update pubspec.ymal with the new version |
Contributor
Author
Sorry, I forgot to update pubspec.yaml |
Contributor
Author
Hi @cyanglaz , What else I can do ? |
mormih
pushed a commit
to mormih/plugins
that referenced
this pull request
Nov 17, 2019
sungmin-park
pushed a commit
to sungmin-park/flutter-plugins
that referenced
this pull request
Dec 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use context cast application in ImagePickerPlugin#onCreate,when depend module context type is application, but depend on aar context type is acitivity, finally cause ClassCastException.
Related Issues
flutter/flutter#41558
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?