[google_sign_in] Add ability to return serverAuthCode #2116

yamarkz · 2019-09-27T03:37:17Z

Description

Supports SERVER_CLIENT_ID(iOS) and default_web_client_id(Android) parameter so that serverAuthCode can be returned.

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
No, this is not a breaking change.

googlebot · 2019-09-27T03:37:30Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

yamarkz · 2019-09-27T04:33:12Z

@googlebot I signed it!

googlebot · 2019-09-27T04:33:17Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

cyanglaz

Thank you for providing this. I left some comments. Could you also update the pubspec?

cyanglaz · 2019-10-15T00:02:19Z

packages/google_sign_in/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 4.0.10


This patch actually updated the response of the public API so it should be 4.1.0

cyanglaz · 2019-10-15T00:03:48Z

...google_sign_in/android/src/main/java/io/flutter/plugins/googlesignin/GoogleSignInPlugin.java

                    "default_web_client_id", "string", registrar.context().getPackageName());
        if (clientIdIdentifier != 0) {
          optionsBuilder.requestIdToken(registrar.context().getString(clientIdIdentifier));
+          optionsBuilder.requestServerAuthCode(registrar.context().getString(clientIdIdentifier));


Is the serverClientId always static? We might want to have it be able to set through code as well. Same in iOS

@cyanglaz
Thank you for review and comment. I'm going to modify them.
About here, In my opinion I think serverClientId is static define, because it is not dynamic value.
but if you have idea or opinion, i give priority to them. please tell me :)

returning serverAuthCode is using my flutter app. so I'm positive about support this modify.

and return null if SERVER_CLIENT_ID value is null.

cyanglaz · 2019-10-15T00:05:32Z

packages/google_sign_in/lib/google_sign_in.dart

      response['idToken'] = _idToken;
    }
+
+    if (response['serverAuthCode'] == null) {


nits: response['serverAuthCode'] ??=_serverAuthCode;

5hanth · 2019-11-07T08:21:12Z

once this is available, we can pass in custom serverClientId ?

cyanglaz

LGTM to the approach. Could you add tests for this change? Also, please update the pubspec with a new version.

yamarkz · 2020-04-24T05:54:30Z

Please review. @ditman, @cyanglaz, @mehmetf

cyanglaz · 2020-04-24T17:23:20Z

packages/google_sign_in/google_sign_in/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 4.5.0
+
+* Add support for getting `serverAuthCode`


nits:

Suggested change

* Add support for getting `serverAuthCode`

* Add support for getting `serverAuthCode`.

cyanglaz · 2020-04-24T17:24:41Z

packages/google_sign_in/google_sign_in/example/android/app/src/main/res/values/strings.xml

+<?xml version="1.0" encoding="utf-8"?>
+<resources>
+    <string name="default_web_client_id">YOUR_WEB_CLIENT_ID</string>
+</resources>


new line EOF

cyanglaz · 2020-04-24T17:25:58Z

...google_sign_in/android/src/main/java/io/flutter/plugins/googlesignin/GoogleSignInPlugin.java

                    "default_web_client_id", "string", registrar.context().getPackageName());
        if (clientIdIdentifier != 0) {
          optionsBuilder.requestIdToken(registrar.context().getString(clientIdIdentifier));
+          optionsBuilder.requestServerAuthCode(registrar.context().getString(clientIdIdentifier));


It seems only gets context from registrar. With v2 embedding, we would need to get the context from the plugin binding.

yamarkz · 2020-04-30T02:43:30Z

I've modified review point. @cyanglaz

Dreamersoul · 2020-05-08T19:41:15Z

hello, any update when this will get merged?

cyanglaz

LGTM

yamarkz added 6 commits September 27, 2019 11:54

Update GoogleSignInPlugin.java

36f7fd0

Update GoogleSignInPlugin.m

9350ff9

Update google_sign_in.dart

722959c

Update version number

55ce6a4

Update AUTHORS

9efd8c4

Update CHANGELOG.md

73f6fa0

yamarkz requested review from cyanglaz and mehmetf as code owners September 27, 2019 03:37

googlebot added the cla: no label Sep 27, 2019

yamarkz added 6 commits September 27, 2019 12:44

Update GoogleSignInPlugin.java

df155e5

Update GoogleSignInPlugin.m

66f969c

Update google_sign_in.dart

3ed41e7

Update AUTHORS

97cbf5b

Update CHANGELOG.md

a24a547

modify conflict

dba9fde

googlebot added cla: yes and removed cla: no labels Sep 27, 2019

cyanglaz reviewed Oct 15, 2019

View reviewed changes

cyanglaz self-assigned this Oct 15, 2019

cyanglaz added the in review label Oct 15, 2019

This was referenced Oct 15, 2019

[google_sign_in] Add ability to request serverAuthCode on Android #1704

Closed

[google_sign_in] Add serverClientId option to return serverAuthCode #879

Closed

cyanglaz suggested changes Nov 7, 2019

View reviewed changes

yamarkz added 3 commits November 8, 2019 15:53

modify variable assignment

beed787

fix conflict

9eb338c

add test case

5227ce8

yamarkz added 8 commits April 24, 2020 10:49

modify conflict

a1b3655

update interface package version

7c7d0a7

remove interface code

866e356

add attribute description comment

1381e78

remove extra line

39ce20b

remove unnecessary code

1c3b37b

modify attribute

42b6410

update package version

bfc4d8e

cyanglaz suggested changes Apr 24, 2020

View reviewed changes

yamarkz added 4 commits April 25, 2020 13:24

modify CHANGELOG.md

f0cc548

add EOF line

6deb8cf

modify conflict

4cf79ac

use v2 embedding context

a373bf7

ditman requested a review from cyanglaz April 30, 2020 18:21

hillelcoren mentioned this pull request May 12, 2020

google_sign_in does not provide offline capabilities flutter/flutter#15796

Closed

modify conflict file

e48ff2c

cyanglaz approved these changes May 19, 2020

View reviewed changes

cyanglaz merged commit 88e85c6 into flutter:master May 19, 2020

yamarkz mentioned this pull request May 21, 2020

[google_sign_in] Fix serverAuthCode getToken on iOS #2788

Closed

13 tasks

EdwinRomelta pushed a commit to EdwinRomelta/plugins that referenced this pull request Jun 11, 2020

[google_sign_in] Add ability to return serverAuthCode (flutter#2116)

8c5bede

jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020

[google_sign_in] Add ability to return serverAuthCode (flutter#2116)

cfa8321

FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020

[google_sign_in] Add ability to return serverAuthCode (flutter#2116)

23ba531

fbcouch mentioned this pull request Dec 20, 2020

[google_sign_in] Fix issue obtaining serverAuthCode on Android and add forceCodeForRefreshToken parameter #3356

Merged

13 tasks

This was referenced Jan 11, 2021

How to set the serverClientID needed for serverAuthCode (Switching from iOS)? flutter/flutter#57945

Closed

[google_sign_in_platform_interface] Add clientId to the method channel #2935

Closed

dreenot mentioned this pull request Apr 27, 2021

[google_sign_in] Fix issue obtaining serverAuthCode on Android and add forceCodeForRefreshToken parameter // Update #3829

Closed

13 tasks

Milvintsiss mentioned this pull request Feb 11, 2022

[google_sign_in] Add doc for iOS auth with SERVER_CLIENT_ID #4747

Merged

11 tasks

		@@ -1,3 +1,7 @@
		## 4.5.0

		* Add support for getting `serverAuthCode`

[google_sign_in] Add ability to return serverAuthCode #2116

[google_sign_in] Add ability to return serverAuthCode #2116

Uh oh!

Conversation

yamarkz commented Sep 27, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Checklist

Breaking Change

Uh oh!

googlebot commented Sep 27, 2019

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!

yamarkz commented Sep 27, 2019

Uh oh!

googlebot commented Sep 27, 2019

Uh oh!

cyanglaz left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yamarkz Nov 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

5hanth commented Nov 7, 2019

Uh oh!

cyanglaz left a comment

Choose a reason for hiding this comment

Uh oh!

yamarkz commented Apr 24, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yamarkz commented Apr 30, 2020

Uh oh!

Dreamersoul commented May 8, 2020

Uh oh!

cyanglaz left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

yamarkz commented Sep 27, 2019 •

edited

Loading

yamarkz Nov 8, 2019 •

edited

Loading