Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@owops
Copy link
Contributor

@owops owops commented Sep 19, 2019

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@owops
Copy link
Contributor Author

owops commented Sep 19, 2019

@googlebot I signed it!

@owops
Copy link
Contributor Author

owops commented Sep 19, 2019

@googlebot I signed it!

@owops
Copy link
Contributor Author

owops commented Sep 19, 2019

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot I signed it!

@owops
Copy link
Contributor Author

owops commented Sep 19, 2019

@googlebot I signed it!

1 similar comment
@owops
Copy link
Contributor Author

owops commented Sep 19, 2019

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@owops owops changed the title swap width and height when source image orientation is left or right [image_picker] swap width and height when source image orientation is left or right Sep 27, 2019
@cyanglaz
Copy link
Contributor

I have opened a similar PR recently #2106 @owops Do you mind review mine? It seems to be the same approach. I am going to close this PR.

@cyanglaz cyanglaz closed this Oct 10, 2019
@owops
Copy link
Contributor Author

owops commented Oct 11, 2019

@cyanglaz Our codes looks exactly the same. I have commit these codes for a long time. I saw that I commit the PR 22 days ago, and your codes commit these codes in 17 days. So why are you closed my PR?

@cyanglaz cyanglaz reopened this Oct 11, 2019
@cyanglaz
Copy link
Contributor

@owops Reopen this one and close the other PR.

Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update pubspec and CHANGLOG with a new version

owops and others added 2 commits October 12, 2019 08:49
@cyanglaz cyanglaz self-assigned this Oct 14, 2019
@cyanglaz
Copy link
Contributor

@owops we are still missing the version updates in pubspec

@owops
Copy link
Contributor Author

owops commented Oct 17, 2019

@owops we are still missing the version updates in pubspec

I'm sorry that I forgot to change the pubspec.yaml when I merge the codes from master.

@owops owops requested a review from cyanglaz October 29, 2019 08:37
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants