Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@mehmetf
Copy link
Contributor

@mehmetf mehmetf commented Aug 20, 2019

No description provided.

Copy link
Contributor

@amirh amirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mehmetf mehmetf merged commit a3f9ce7 into flutter:master Aug 20, 2019
@mehmetf mehmetf deleted the 56 branch August 20, 2019 22:04
@ened
Copy link
Contributor

ened commented Aug 22, 2019

@mehmetf @amirh how could we possibly write a test for that?
I was just working on adding test for path_provider and this did fall through! See #1990.

  test('getApplicationSupportDirectory', () async {
    final Directory result = await getApplicationSupportDirectory();
    final String uuid = Uuid().v1();
    final File file = File('${result.path}/$uuid.txt');
    file.writeAsStringSync('Hello world!');
    expect(file.readAsStringSync(), 'Hello world!');
    expect(result.listSync(), isNotEmpty);
    file.deleteSync();
  });

@rockingdice
Copy link

Any ETA about v1.2.1 of path_provider on pub?
I met this issue:
java.lang.IllegalStateException: Reply already submitted which is probably this fix can make it work.

sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request Dec 17, 2019
* [pathprovider] Fix fall through bug
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants