[webview_flutter] Comment asking to extend WebViewPlatformController #1982
Conversation
| /// An instance implementing this interface is passed to the `onWebViewPlatformCreated` callback that is | ||
| /// passed to [WebViewPlatformBuilder#onWebViewPlatformCreated]. | ||
| /// | ||
| /// Platform implementations that live in a separate package should extend this class rather than |
There was a problem hiding this comment.
Do you think there's a case where a platform implementation would ever deliberately want to be broken instead of getting a runtime error method added to them silently? In some cases I could see people preferring to be obviously broken by newer versions instead of having to figure out themselves if there's any new methods that will throw runtime errors. But I'm not sure if that's reasonable.
If you think it's theoretically possible that some people would prefer to be broken at compile time by new versions, I think this should be reworded to something like "Additions to this class aren't treated as breaking changes. Be careful if you choose to implement instead of extend this class as you will be broken by newly added methods instead of getting default implementations."
There was a problem hiding this comment.
That's a really good question.
I think that ideally we wouldn't want builds to be broken after upgrading a minor version of a dependency. If we allow platform implementers to implement this class then every addition to this class is a breaking change and requires a major version bump (potentially to the platform interface which may be versioned separately). Technically this is also the case for any method addition to any class.
I see how treating additions to this class as breaking change can make sense, though it's a longer discussion so not dumping my thoughts on this PR.
…tion. (flutter#1982) * [flutterfire] Mark cloud_firestore and cloud_functions as available for Web in the main feature matrix. * [cloud_firestore] Add Web integration instructions to README. * [cloud_firestore_web] Add post-endorsement web integration instructions.
3 participants
No description provided.