Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@jerryzhoujw
Copy link
Contributor

@jerryzhoujw jerryzhoujw commented Aug 7, 2019

Description

For iOS, NSLibraryDirectory are more used for application data like sqlite.db or images which would like to be capacity to persistent, backed up and not visible in iTunes File Sharing when UIFileSharingEnabled is TRUE in app's plist file.

From StackOverFlow discuss: Path Directory Usable in iOS

  • NSDocumentDirectory is Documents/ (persistent, backed up, may be visible in iTunes)
  • NSLibraryDirectory is Library/ (persistent, backed up, not visibe to the user)
  • NSCachesDirectory is Library/Caches/ (not backed up, may be cleared by system)

From iOS framework:

  • NSLibraryDirectory, // various documentation, support, and configuration files, resources (Library)
  • NSApplicationSupportDirectory = 14, // location of application support files (plug-ins, etc) (Library/Application Support)

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@jerryzhoujw jerryzhoujw force-pushed the dev/path_provider_add_getApplicationLibraryDirectory branch 2 times, most recently from f0b0d7e to 0cc7bff Compare August 7, 2019 08:38
Copy link
Contributor

@collinjackson collinjackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we call this getLibraryDirectory to match the naming on iOS?

@jerryzhoujw
Copy link
Contributor Author

Should we call this getLibraryDirectory to match the naming on iOS?

yes we can

@jerryzhoujw jerryzhoujw force-pushed the dev/path_provider_add_getApplicationLibraryDirectory branch 4 times, most recently from 23bfe11 to 8e0c2fd Compare August 8, 2019 03:20
@collinjackson collinjackson self-requested a review August 8, 2019 20:44
@jerryzhoujw jerryzhoujw force-pushed the dev/path_provider_add_getApplicationLibraryDirectory branch from 8e0c2fd to 791a223 Compare August 15, 2019 07:09
@jerryzhoujw
Copy link
Contributor Author

@collinjackson Do I better to not do git rebase after PR create ? I have asked someone, but maybe I do better ask review directly

@ened
Copy link
Contributor

ened commented Aug 15, 2019

@jerryzhoujw Great PR.

@collinjackson can we get this reviewed again soon?

@collinjackson collinjackson self-assigned this Aug 26, 2019
@ened ened mentioned this pull request Aug 29, 2019
13 tasks
@collinjackson collinjackson merged commit 518d342 into flutter:master Sep 5, 2019
@jerryzhoujw jerryzhoujw deleted the dev/path_provider_add_getApplicationLibraryDirectory branch September 8, 2019 07:21
ened pushed a commit to ened/plugins that referenced this pull request Sep 9, 2019
noelmansour pushed a commit to snowble/plugins that referenced this pull request Nov 13, 2019
mormih pushed a commit to mormih/plugins that referenced this pull request Nov 17, 2019
sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request Dec 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants