This repository was archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[path_provider] add getApplicationLibraryDirectory #1953
Merged
collinjackson
merged 5 commits into
flutter:master
from
jerryzhoujw:dev/path_provider_add_getApplicationLibraryDirectory
Sep 5, 2019
Merged
[path_provider] add getApplicationLibraryDirectory #1953
collinjackson
merged 5 commits into
flutter:master
from
jerryzhoujw:dev/path_provider_add_getApplicationLibraryDirectory
Sep 5, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f0b0d7e to
0cc7bff
Compare
Contributor
collinjackson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we call this getLibraryDirectory to match the naming on iOS?
Contributor
Author
yes we can |
23bfe11 to
8e0c2fd
Compare
8e0c2fd to
791a223
Compare
Contributor
Author
|
@collinjackson Do I better to not do |
Contributor
|
@jerryzhoujw Great PR. @collinjackson can we get this reviewed again soon? |
…etApplicationLibraryDirectory
13 tasks
…dd_getApplicationLibraryDirectory
collinjackson
approved these changes
Sep 5, 2019
12 tasks
ened
pushed a commit
to ened/plugins
that referenced
this pull request
Sep 9, 2019
12 tasks
noelmansour
pushed a commit
to snowble/plugins
that referenced
this pull request
Nov 13, 2019
* [path_provider] add getLibraryDirectory
mormih
pushed a commit
to mormih/plugins
that referenced
this pull request
Nov 17, 2019
* [path_provider] add getLibraryDirectory
sungmin-park
pushed a commit
to sungmin-park/flutter-plugins
that referenced
this pull request
Dec 17, 2019
* [path_provider] add getLibraryDirectory
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For iOS,
NSLibraryDirectoryare more used for application data like sqlite.db or images which would like to be capacity to persistent, backed up and not visible in iTunes File Sharing whenUIFileSharingEnabledisTRUEin app's plist file.From StackOverFlow discuss: Path Directory Usable in iOS
NSDocumentDirectoryisDocuments/(persistent, backed up, may be visible in iTunes)NSLibraryDirectoryisLibrary/(persistent, backed up, not visibe to the user)NSCachesDirectoryisLibrary/Caches/(not backed up, may be cleared by system)From iOS framework:
NSLibraryDirectory, // various documentation, support, and configuration files, resources (Library)NSApplicationSupportDirectory= 14, // location of application support files (plug-ins, etc) (Library/Application Support)Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?