This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[firebase_auth] Fixes for iOS auth crash on failed sign-in #1928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collinjackson
changed the title
kroikie
approved these changes
Jul 29, 2019
|
|
||
| test('email auth', () async { | ||
| final Random random = Random(); | ||
| final String testEmail = 'testuser${random.nextInt(100000000)}@gmail.com'; |
Contributor
There was a problem hiding this comment.
Is there no concern of a clash here which may make the test flaky?
Contributor
Author
There was a problem hiding this comment.
It's unlikely since the user is deleted at the end of the test.
I am reluctant to roll my own random string generator since there's already a package for that: https://pub.dev/packages/random_string
Switched to using uuid for now.
mithun-mondal
pushed a commit
to bKash-developer/archived_plugins
that referenced
this pull request
Aug 6, 2019
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds integration testing
Fixes flutter/flutter#37160