[multiple] Add licenses #1908
[multiple] Add licenses #1908
Conversation
cyanglaz
left a comment
cyanglaz
left a comment
There was a problem hiding this comment.
Some places we use 'Chromium authors' and some we use 'Flutter authors', are there any differences? Should they be consistent?
| (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE | ||
| OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | ||
| -------------------------------------------------------------------------------- | ||
| aFileChooser |
There was a problem hiding this comment.
This is required as image picker is using the aFileChooser which uses apatch license.
There was a problem hiding this comment.
Yea it has to match the author name in the plugin LICENSE file. I added more info to the PR description.
There was a problem hiding this comment.
I also didn't mean to change this file. I had to update my script :)
|
does this add a test to enforce it? |
|
@Hixie Yes, I created this PR that adds a command line tool that will enforce it and can automatically add them to your files: https://github.com/flutter/plugin_tools/pull/48 |
|
Please update the PR description to reflect what this PR is doing (add/update licenses) |
…ns_web (flutter#1908) * create no-op stubs for iOS/Android in cloud_functions_web * Update CHANGELOG * Update version number to accomodate check. * Remove AndroidX from no-op plugin implementation
5 participants
Checks that all plugins correctly contains licenses.
This check enforces the following rules:
Submitting this despite ipa tests continue to timeout. This will be reverted if it doesn't pass the general test after submission.