Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@juliocbcotta
Copy link
Contributor

Description

This PR tries to fix a memory leak in image picker plugin by unregistering the ActivityLifecycleCallbacks in the onDestroy of the view.

Related Issues

flutter/flutter#36520

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM!

@cyanglaz
Copy link
Contributor

CI seems not happy about some java unit tests

@juliocbcotta
Copy link
Contributor Author

@cyanglaz it is green.

@cyanglaz cyanglaz added the submit queue The Flutter team is in the process of landing this PR. label Jul 29, 2019
@cyanglaz cyanglaz self-assigned this Jul 29, 2019
@cyanglaz cyanglaz merged commit 57201c9 into flutter:master Jul 29, 2019
mithun-mondal pushed a commit to bKash-developer/archived_plugins that referenced this pull request Aug 6, 2019
@qwerqwq
Copy link

qwerqwq commented Sep 12, 2019

image_picker 有图片压缩的功能api吗

@cyanglaz
Copy link
Contributor

@qwerqwq 目前还没有。如果您有兴趣可以开一个pr :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes submit queue The Flutter team is in the process of landing this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants