Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[google_maps_flutter] Adds support for displaying the traffic layer #1767

Merged
iskakaushik merged 2 commits into from
Aug 23, 2019
Merged

[google_maps_flutter] Adds support for displaying the traffic layer #1767

iskakaushik merged 2 commits into from
Aug 23, 2019

Conversation

@josh-burton
Copy link
Contributor

@josh-burton josh-burton commented Jun 24, 2019

Description

Adds a toggle for the Google Maps Traffic layer.

Related Issues

flutter/flutter#25334

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@josh-burton josh-burton force-pushed the google-maps-traffic branch from 4db64de to 09ab62c Compare July 10, 2019 08:33
@josh-burton
Copy link
Contributor Author

josh-burton commented Jul 10, 2019

@iskakaushik @amirh would really appreciate your review if you get a chance.

@josh-burton josh-burton force-pushed the google-maps-traffic branch from 09ab62c to f638b0b Compare July 13, 2019 04:35
@josh-burton josh-burton force-pushed the google-maps-traffic branch from f638b0b to 67b538c Compare July 31, 2019 23:36
@iskakaushik
Copy link
Contributor

iskakaushik commented Aug 6, 2019

Can you add some tests which get isTrafficLayerEnabled information from the underlying google maps sdk? Take a look at https://github.com/flutter/plugins/pull/1809/files#diff-348a670c92aab89f861ab1aa02260a7b for example on how to do this. Thanks!

@josh-burton josh-burton force-pushed the google-maps-traffic branch from 67b538c to 8c67b92 Compare August 7, 2019 22:19
@josh-burton
Copy link
Contributor Author

josh-burton commented Aug 8, 2019

@iskakaushik done :)

@josh-burton josh-burton force-pushed the google-maps-traffic branch 2 times, most recently from 33eb17c to b57150f Compare August 20, 2019 05:20
@josh-burton
Copy link
Contributor Author

josh-burton commented Aug 20, 2019

@iskakaushik do you require any other changes for this to merge?

@sensudipta
Copy link

sensudipta commented Aug 23, 2019

@iskakaushik I have been waiting for this merge to complete, my production app needs the feature this branch provides. Thanks in advance.

@iskakaushik iskakaushik merged commit 18352b2 into flutter:master Aug 23, 2019
@iskakaushik
Copy link
Contributor

iskakaushik commented Aug 23, 2019

Thanks for this contribution!

@iskakaushik iskakaushik mentioned this pull request Aug 23, 2019
Closed
@warrenchin warrenchin mentioned this pull request Oct 9, 2019
Closed
@monnguyen2512
Copy link

monnguyen2512 commented Dec 15, 2019

@athornz please fix trafficEnabled on Android

@josh-burton
Copy link
Contributor Author

josh-burton commented Dec 15, 2019

@monnguyen2512 should be an easy fix - maybe give it a go yourself?

@monnguyen2512
Copy link

monnguyen2512 commented Dec 15, 2019

@athornz ok, I fixed it

sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request Dec 17, 2019
@josh-burton
[google_maps_flutter] Adds support for displaying the traffic layer (f…
9055fd1 
…lutter#1767)

* [google_maps_flutter] Adds support for displaying the traffic layer

* [google_maps_flutter] Adds traffic layer tests
@josh-burton josh-burton deleted the google-maps-traffic branch February 3, 2020 23:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@amirh amirh Awaiting requested review from amirh

@iskakaushik iskakaushik Awaiting requested review from iskakaushik

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@josh-burton @iskakaushik @sensudipta @monnguyen2512 @googlebot