Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[video_player] Android: gain audio focus when playing a video #34646 #1755

Closed
recastrodiaz wants to merge 5 commits into from
Closed

[video_player] Android: gain audio focus when playing a video #34646 #1755

recastrodiaz wants to merge 5 commits into from

Conversation

@recastrodiaz
Copy link
Contributor

@recastrodiaz recastrodiaz commented Jun 18, 2019 •
edited
Loading

Description

Stop mixing audio from 3rd party video/music players when a video is played.

Solution based on https://medium.com/google-exoplayer/easy-audio-focus-with-exoplayer-a2dcbbe4640e

Related Issues

Fixes flutter/flutter#34646

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

cyanglaz
cyanglaz suggested changes Jul 17, 2019
View reviewed changes
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! I think we should add this as a new feature when building the video player to let developer choose if they want the video player to control the focus. It'd be great if you can add the equivalent for iOS as well.

@recastrodiaz
Copy link
Contributor Author

recastrodiaz commented Aug 1, 2019

Hi @cyanglaz Thanks for the review and apologies for the slow response.

https://github.com/flutter/plugins/pull/1174/files implements the iOS version of this. @wwwdata would it be ok to merge your branch with this one? or do you want me to push the Android code to your branch? In any case we should keep one PR that implements the mixing of audio. Let me know what you think. Thanks!

@cyanglaz
Copy link
Contributor

cyanglaz commented Aug 1, 2019

I have reviewed #1174 and yeah these 2 should be combined easily. Let's wait for @wwwdata's response to your ping or my review comments.

@cyanglaz cyanglaz self-assigned this Aug 1, 2019
@wwwdata wwwdata mentioned this pull request Aug 5, 2019
Closed
@recastrodiaz
Copy link
Contributor Author

recastrodiaz commented Aug 7, 2019

Closing in favour of #1174

@recastrodiaz recastrodiaz deleted the audioFocus branch August 7, 2019 17:02
@iampato iampato mentioned this pull request Nov 30, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@iskakaushik iskakaushik Awaiting requested review from iskakaushik

1 more reviewer

@cyanglaz cyanglaz cyanglaz requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cyanglaz cyanglaz

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[video_player] Stop playing background music/audio when a video is played on Android

3 participants

@recastrodiaz @cyanglaz @googlebot