Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@OreOreDa
Copy link
Contributor

Description

Create a new Flutter project with "flutter create"
Add the latest google maps flutter plugin in pubspec.yaml
build for iOS fails with latest version of XCode / Flutter SDK with error "GoogleMapsBase not found", because of GoogleMaps.framework headers:
#if __has_feature(modules)
@import GoogleMapsBase; <--- this is taken by default with a non-modified Flutter project
#else
#import <GoogleMapsBase/GoogleMapsBase.h>
#endif

This is a known issue, it has been solved for React Native : https://github.com/googlemaps/google-maps-ios-utils/pull/20/files

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@OreOreDa
Copy link
Contributor Author

Some checks failed due to github timeouts (?), I re created this PR to have the checks run again, and have the green mark

@iskakaushik
Copy link
Contributor

@OreOreDa could you please edit the pubspec.yaml change version to 0.5.18 and also add a new changelog entry, not edit the current one?

@OreOreDa
Copy link
Contributor Author

Sure, Iska 👍 Done

@iskakaushik
Copy link
Contributor

LGTM. This fixes flutter/flutter#34042

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants