Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

## Description #1706

Closed
collinjackson wants to merge 29 commits into from
Closed

## Description #1706

collinjackson wants to merge 29 commits into from

Conversation

@collinjackson
Copy link
Contributor

@collinjackson collinjackson commented Jun 5, 2019 •
edited
Loading

(ignore this PR)

awazgyawali and others added 29 commits May 8, 2019 19:30
@awazgyawali
Migrated linkWithCredential function to user object
6f25896
@awazgyawali
Fixed test
3f9839f
@awazgyawali
added change log and increased version of the plugin
98917f5
@awazgyawali
Minor fixes
4a106f7
@awazgyawali
Added collection group query
a77e8f5
@awazgyawali
Added an assertion
d509a55
@awazgyawali
Formatted files
e811d07
@awazgyawali
Removed keys
77ceefe
@awazgyawali
Merged with master
66124e5
@awazgyawali
Minor changes
5655c88
@awazgyawali
Completed on IOS too
677c3f7
@awazgyawali
Making google formatter happy
2649b9f
@awazgyawali
Added changelog and bumped version
3cbc15e
@awazgyawali
Changed BOOL casting to NSNumber casting
29fad5e
@awazgyawali
decapitalized collection word
93f4ac7
@awazgyawali
Changrd bool variable name
06c18e4
@awazgyawali
Added newer field value to the test
8d691e2
@awazgyawali
Added some test for collection group query
54c4b0f
@awazgyawali
Changed name od the tests
10f11b0
@awazgyawali
Formatted test file
4da92b2
@awazgyawali
Fixed test fail case
5630fe4
@awazgyawali
Added som test(UNtested)
6721d26
@awazgyawali
Merge branch 'master' into group_collection_query
6dad41d
@collinjackson
Merge remote-tracking branch 'origin/master' into group_collection_query
5d87484
@collinjackson
Fix test
930a47f
@collinjackson
Merge remote-tracking branch 'origin/master' into group_collection_query
a1ced47
@collinjackson
Fix tests
ab271f8
@collinjackson
Fix merge damage
8d87d51
@collinjackson
Ensure that CocoaPods on Cirrus is always the latest version.
0c964da
@collinjackson collinjackson requested a review from kroikie as a code owner June 5, 2019 03:41
@googlebot
Copy link

googlebot commented Jun 5, 2019

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@udnisap udnisap mentioned this pull request Jul 8, 2019
Merged
12 tasks
@mklim mklim mentioned this pull request Nov 13, 2019
Merged
13 tasks
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
@cbenhagen @franciscojma86
[cloud_firestore] Add macOS support (flutter#1706)
0b13c92 
* Add macOS support

* Share implementation between iOS and macOS

* Fix version number

* Remove UserAgent.h

* Add macos dir to example

* Depend on firebase_core 0.4.4

* Define platform in podspec

* Allow outgoing connections

* Add .xcworkspace

Co-authored-by: Francisco Magdaleno <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kroikie kroikie Awaiting requested review from kroikie

Assignees

No one assigned

Labels

cla: no

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@collinjackson @googlebot @awazgyawali