Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@ened
Copy link
Contributor

@ened ened commented Apr 30, 2019

Description

During network playback (HTTP), the duration may take a little longer to determine.
Until it is determined, the player must not be considered "initialized", else div/0 will occur during the progress indicator display.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@ened ened requested a review from iskakaushik as a code owner April 30, 2019 04:54
@ened
Copy link
Contributor Author

ened commented May 13, 2019

@iskakaushik do you need further information approve this PR?

@iskakaushik
Copy link
Contributor

LGTM

@iskakaushik iskakaushik merged commit 445adad into flutter:master May 13, 2019
@ened ened deleted the video-player-ios-http-duration branch June 6, 2019 01:23
WoodyGuo pushed a commit to liuwei1130/plugins that referenced this pull request Jun 27, 2019
…lutter#1554)

* [video_player] Prevent Div/0 during network playback initialization.

* [video_player] Bump version to 0.10.1

* Remove unused logs.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants