This repository was archived by the owner on Feb 22, 2023. It is now read-only.
add driver test command to cirrus #1342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amirh
reviewed
Mar 15, 2019
collinjackson
changed the title
this should be reverted
collinjackson
commented
Mar 15, 2019
This was referenced Mar 15, 2019
This reverts commit fa8f840.
amirh
reviewed
Mar 15, 2019
amirh
reviewed
Mar 15, 2019
Contributor
amirh
left a comment
amirh
left a comment
There was a problem hiding this comment.
Not sure what are the implications of increasing the resource requirements? (will we run our of cloud credits faster?) worth running this by @gspencergoog
Other than that and the shard count nit LGTM
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
This teaches Cirrus to run the new drive-examples command added in flutter/plugin_tools#29 on iOS and Android simulators. I'm sharding the plugins tests more and requesting more powerful Linux VMs to ensure that the tests don't time out now that they're running simulators.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#26080
This teaches Cirrus to run the new drive-examples command added in flutter/plugin_tools#29 on iOS and Android simulators.
I'm sharding the plugins tests more and requesting more powerful Linux VMs to ensure that the tests don't time out now that they're running simulators.